tweak BigQuery default project detection #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| throw new RuntimeException( | ||
| s"Property $PROJECT_KEY not set. Use -D$PROJECT_KEY=<BILLING_PROJECT>") | ||
| instance = if (sys.props(PROJECT_KEY) != null) { | ||
| BigQueryClient(sys.props(PROJECT_KEY)) |
There was a problem hiding this comment.
the only reason this is still here is for backwards compatibility, correct?
There was a problem hiding this comment.
Or in environments with no default, i.e. Travis.
|
👍 |
nevillelyh
added a commit
that referenced
this pull request
Jul 19, 2016
* use DefaultProjectFactory to detect project * detect default project in BigQueryClient Conflicts: scio-bigquery/src/main/scala/com/spotify/scio/bigquery/BigQueryClient.scala scio-repl/src/main/scala/com/spotify/scio/repl/ScioILoop.scala
nevillelyh
added a commit
that referenced
this pull request
Oct 21, 2016
* use DefaultProjectFactory to detect project * detect default project in BigQueryClient Conflicts: scio-bigquery/src/main/scala/com/spotify/scio/bigquery/BigQueryClient.scala scio-repl/src/main/scala/com/spotify/scio/repl/ScioILoop.scala
nevillelyh
added a commit
that referenced
this pull request
Jan 11, 2017
* use DefaultProjectFactory to detect project * detect default project in BigQueryClient Conflicts: scio-bigquery/src/main/scala/com/spotify/scio/bigquery/BigQueryClient.scala scio-repl/src/main/scala/com/spotify/scio/repl/ScioILoop.scala
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.